Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ConfigManagerTest to Include Assertions for Automated Validation #711

Merged

Conversation

Codegass
Copy link
Contributor

Fix #710

Description:

This pull request introduces an enhancement to the ConfigManagerTest, specifically the testBasicReplacement method. Previously, this test method relied on manual verification of test outcomes through console output, which is not in line with automated testing best practices. To address this, the proposed changes refactor the test to utilize AtomicReference for capturing changes in property values and assert these changes using JUnit Jupiter's Assertions.assertEquals. This modification ensures that the test outcomes can be automatically and precisely validated, thus improving the overall reliability and efficiency of our testing process.

Key Changes:

  • Utilized AtomicReference to capture changes in property values within the test.
  • Replaced manual console output verification with Assertions.assertEquals to automatically verify the expected behavior.

@rgallardo-netflix rgallardo-netflix merged commit 084a29d into Netflix:2.x Mar 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConfigManagerTest.testBasicReplacement is using the Print instead of Assert in Testing
2 participants